richardantal commented on code in PR #108:
URL:
https://github.com/apache/phoenix-connectors/pull/108#discussion_r1342490759
##########
phoenix5-spark3/src/main/java/org/apache/phoenix/spark/sql/connector/writer/PhoenixDataSourceWriteOptions.java:
##########
@@ -28,20 +28,20 @@
class PhoenixDataSourceWriteOptions implements Serializable {
private final String tableName;
- private final String zkUrl;
+ private final String jdbcUrl;
private final String tenantId;
private final String scn;
private final StructType schema;
private final boolean skipNormalizingIdentifier;
private final Properties overriddenProps;
- private PhoenixDataSourceWriteOptions(String tableName, String zkUrl,
String scn,
+ private PhoenixDataSourceWriteOptions(String tableName, String jdbcUrl,
String scn,
String tenantId, StructType schema,
boolean skipNormalizingIdentifier,
Properties overriddenProps) {
if (tableName == null) {
throw new NullPointerException();
}
- if (zkUrl == null) {
+ if (jdbcUrl == null) {
Review Comment:
Why don't you throw IllegalArgumentException if the schema or the
overriddenPropsos null?
Like it is done int the phoenix5-spark connector
##########
phoenix5-spark/src/main/java/org/apache/phoenix/spark/datasource/v2/PhoenixDataSource.java:
##########
@@ -42,6 +45,7 @@ public class PhoenixDataSource implements DataSourceV2,
ReadSupport, WriteSupp
private static final Logger logger =
LoggerFactory.getLogger(PhoenixDataSource.class);
public static final String SKIP_NORMALIZING_IDENTIFIER =
"skipNormalizingIdentifier";
public static final String ZOOKEEPER_URL = "zkUrl";
Review Comment:
You added a Deprecated tag to the ZOOKEEPER_URL in
phoenix5-spark3/src/main/java/org/apache/phoenix/spark/sql/connector/PhoenixDataSource.java
why not here too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
