[
https://issues.apache.org/jira/browse/PHOENIX-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771204#comment-17771204
]
ASF GitHub Bot commented on PHOENIX-7057:
-----------------------------------------
stoty commented on PR #1699:
URL: https://github.com/apache/phoenix/pull/1699#issuecomment-1743406105
Thanks for the review @shahrs87 .
As this code is only used for the old non globally consistent index
implementation, and the bug comes from a copy-paste error in my refactor, I
wouldn't spend a lot of time on writing a test for this.
> Potential bug in MetadataEndpointImpl#updateIndexState.
> -------------------------------------------------------
>
> Key: PHOENIX-7057
> URL: https://issues.apache.org/jira/browse/PHOENIX-7057
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.2.0, 5.1.4
> Reporter: Rushabh Shah
> Assignee: Istvan Toth
> Priority: Major
>
> This is the relevant [code
> snippet|https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L4067-L4073].
> {code}
> try (RegionScanner countScanner =
> region.getScanner(new Scan(get))) {
> List<Cell> countCells = new ArrayList<>();
> scanner.next(countCells);
> count = Result.create(countCells)
> .getValue(TABLE_FAMILY_BYTES,
>
> PhoenixDatabaseMetaData.PENDING_DISABLE_COUNT_BYTES);
> }
> {code}
> Instead of scanner.next, should it have been countScanner.next?
> This is the change that have introduced a potential bug. PHOENIX-6658
> [~stoty] WDYT?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
