tkhurana commented on code in PR #1701:
URL: https://github.com/apache/phoenix/pull/1701#discussion_r1349145357
##########
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##########
@@ -917,7 +954,8 @@ private void prepareIndexMutations(BatchMutateContext
context, List<IndexMaintai
for (Pair<IndexMaintainer, HTableInterfaceReference> pair :
indexTables) {
IndexMaintainer indexMaintainer = pair.getFirst();
HTableInterfaceReference hTableInterfaceReference =
pair.getSecond();
- if (nextDataRowState != null) {
+ if (nextDataRowState != null &&
Review Comment:
I think we are not handling the case here when there is an existing row in
the index but after an update the new row doesn't satisfy the index where
condition so it needs to be deleted from the index table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
