[
https://issues.apache.org/jira/browse/PHOENIX-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774704#comment-17774704
]
ASF GitHub Bot commented on PHOENIX-7063:
-----------------------------------------
lokiore commented on code in PR #1706:
URL: https://github.com/apache/phoenix/pull/1706#discussion_r1357469758
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionQueryServicesTestImpl.java:
##########
@@ -69,12 +69,14 @@ public ConnectionQueryServicesTestImpl(QueryServices
services, ConnectionInfo in
@Override
public void addConnection(PhoenixConnection connection) throws
SQLException {
+ super.addConnection(connection);
Review Comment:
Aaah I see....... ✌️
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionQueryServicesTestImpl.java:
##########
@@ -69,12 +69,14 @@ public ConnectionQueryServicesTestImpl(QueryServices
services, ConnectionInfo in
@Override
public void addConnection(PhoenixConnection connection) throws
SQLException {
+ super.addConnection(connection);
Review Comment:
Aaah I see....... ✌️
> Track and account garbage collected phoenix connections
> -------------------------------------------------------
>
> Key: PHOENIX-7063
> URL: https://issues.apache.org/jira/browse/PHOENIX-7063
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.1.3
> Reporter: Jacob Isaac
> Assignee: Lokesh Khurana
> Priority: Major
>
> In production env, misbehaving clients can forget to close Phoenix
> connections. This can result in Phoenix connections leaking.
> Moreover, when Phoenix connections are tracked and limited by the
> GLOBAL_OPEN_PHOENIX_CONNECTIONS metrics counter per jvm, it can lead to
> client requests for Phoenix connections being rejected.
> Tracking and keeping count of garbage collected Phoenix connections can
> alleviate the above issues.
> Providing additional logging during such reclaims will provide additional
> insights into a production env.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
