shahrs87 commented on code in PR #1666:
URL: https://github.com/apache/phoenix/pull/1666#discussion_r1361042719
##########
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -3471,6 +3476,12 @@ public Void call() throws Exception {
LOGGER.info("An instance of
ConnectionQueryServices was created.");
openConnection();
hConnectionEstablished = true;
+ boolean lastDDLTimestampValidationEnabled
Review Comment:
I don't think think we can keep populating regionservers guarded by
LAST_DDL_TIMESTAMP_VALIDATION_ENABLED conf for a long time. In future if some
other feature wants to read this regionservers list but don't want to enable
LAST_DDL_TIMESTAMP_VALIDATION_ENABLED conf property.
For time being it is fine, but lets open a jira to see why Permission
related IT are failing with this change. Before we merge this feature into
master branch, we will have to fix that jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
