[
https://issues.apache.org/jira/browse/PHOENIX-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775864#comment-17775864
]
ASF GitHub Bot commented on PHOENIX-7025:
-----------------------------------------
shahrs87 commented on code in PR #1666:
URL: https://github.com/apache/phoenix/pull/1666#discussion_r1361042719
##########
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -3471,6 +3476,12 @@ public Void call() throws Exception {
LOGGER.info("An instance of
ConnectionQueryServices was created.");
openConnection();
hConnectionEstablished = true;
+ boolean lastDDLTimestampValidationEnabled
Review Comment:
I don't think think we can keep populating regionservers guarded by
LAST_DDL_TIMESTAMP_VALIDATION_ENABLED conf for a long time. In future if some
other feature wants to read this regionservers list but don't want to enable
LAST_DDL_TIMESTAMP_VALIDATION_ENABLED conf property.
For time being it is fine, but lets open a jira to see why Permission
related IT are failing with this change. Before we merge this feature into
master branch, we will have to fix that jira.
> Create a new RPC to validate last ddl timestamp for read requests.
> ------------------------------------------------------------------
>
> Key: PHOENIX-7025
> URL: https://issues.apache.org/jira/browse/PHOENIX-7025
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Rushabh Shah
> Assignee: Palash Chauhan
> Priority: Major
>
> Introduce a new RPC request from phoenix client to any region server via
> PhoenixRegionServerEndpoint#validateLastDDLTimestamp. Since the last ddl
> timestamp cache is maintained by all the regionservers, you can choose any
> regionserver randomly. In future, we can make this rpc more resilient by
> sending this rpc to multiple regionservers simultaneously.
> If phoenix client throws StaleMetadataCacheException then invalidate the
> cache on the client side and retry executeQuery method while fetching the
> updated metadata from SYSCAT regionserver.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
