[ 
https://issues.apache.org/jira/browse/PHOENIX-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776285#comment-17776285
 ] 

ASF GitHub Bot commented on PHOENIX-7044:
-----------------------------------------

tkhurana commented on code in PR #1708:
URL: https://github.com/apache/phoenix/pull/1708#discussion_r1362475713


##########
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -1529,6 +1526,11 @@ public MutationState createIndex(CreateIndexStatement 
statement, byte[][] splits
                 if (expressionIndexCompiler.isAggregate()) {
                     throw new 
SQLExceptionInfo.Builder(SQLExceptionCode.AGGREGATE_EXPRESSION_NOT_ALLOWED_IN_INDEX).build().buildException();
                 }
+                if (expressionIndexCompiler.isJsonFragment()) {

Review Comment:
   Can you add a test case for this too 





> Support Index on a generated column that extracts a scalar value from the 
> JSON column
> -------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-7044
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7044
>             Project: Phoenix
>          Issue Type: Sub-task
>          Components: phoenix
>            Reporter: Ranganath Govardhanagiri
>            Assignee: Ranganath Govardhanagiri
>            Priority: Major
>
> As per the Design doc attached we can implement the below proposal:
> Using index expressions: Phoenix lets index’s PK to be defined as certain 
> expressions. Aggregate (sum()), stateless(a constant value) or 
> non-deterministic(rand()) is not allowed. But expressions like (mycol/2) is 
> allowed. The Json function could be used as expression with some code 
> changes. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to