[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780479#comment-17780479
]
ASF GitHub Bot commented on PHOENIX-7038:
-----------------------------------------
mihir6692 commented on code in PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#discussion_r1374848007
##########
phoenix-core/src/main/java/org/apache/phoenix/monitoring/PhoenixConnectionProfileMetric.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.monitoring;
+
+/**
+ * Class that exposes the various phoenix metrics collected
+ * at the Phoenix Connection Profile level. Because metrics are dynamic in
nature,
+ * it is not guaranteed that the state exposed will always be in sync with
each other.
+ * One should use these metrics primarily for monitoring and debugging
purposes.
+ */
+public interface PhoenixConnectionProfileMetric extends Metric {
Review Comment:
Done. Changed everywhere.
##########
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -443,6 +448,11 @@ public ConnectionQueryServicesImpl(QueryServices services,
ConnectionInfo connec
for (Entry<String,String> entry : connectionInfo.asProps()) {
config.set(entry.getKey(), entry.getValue());
}
+ if (connectionInfo.getPrincipal() != null) {
+ config.set(QUERY_SERVICES_NAME, connectionInfo.getPrincipal());
+ }
+ LOGGER.info(String.format("CQS initialized with connection profile :
%s",
Review Comment:
done
> Implement Connection Query Service Metrics
> ------------------------------------------
>
> Key: PHOENIX-7038
> URL: https://issues.apache.org/jira/browse/PHOENIX-7038
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Mihir Monani
> Assignee: Mihir Monani
> Priority: Major
>
> With JDBC connection profile string, Clients can provide connection profile
> name. With use of Connection Profile, different kinds of clients/use-case in
> single JVM can create connection with different configuration like time-outs,
> retries, sleep between retries.
> Connection URL Example : jdbc:phoenix:localhost:2181:CONN_PROFILE_2
> Here CONN_PROFILE_2 is connection profile name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
