NihalJain commented on code in PR #140:
URL:
https://github.com/apache/phoenix-queryserver/pull/140#discussion_r1380662025
##########
pom.xml:
##########
@@ -370,6 +370,49 @@
</excludes>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>banned-commons-logging</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <bannedDependencies>
+ <excludes>
+
<exclude>commons-logging:commons-logging</exclude>
+ </excludes>
+ <message>We don't use commons-logging
any more, so do not depend on it directly.</message>
+
<searchTransitive>false</searchTransitive>
+ </bannedDependencies>
+ </rules>
+ </configuration>
+ </execution>
+ <execution>
+ <id>banned-other-logging-framework</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <bannedDependencies>
+ <excludes>
+ <exclude>log4j:*</exclude>
Review Comment:
Ah we could just restrict imports via
https://github.com/skuzzle/restrict-imports-enforcer-rule. But
maven-enforcer-plugin will ban transitive dependecies as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
