jpisaac commented on code in PR #1709:
URL: https://github.com/apache/phoenix/pull/1709#discussion_r1385655483
##########
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -1598,12 +1600,14 @@ public MutationState createIndex(CreateIndexStatement
statement, byte[][] splits
}
}
+ Configuration config =
connection.getQueryServices().getConfiguration();
// for view indexes
if (dataTable.getType() == PTableType.VIEW) {
String physicalName = dataTable.getPhysicalName().getString();
physicalSchemaName =
SchemaUtil.getSchemaNameFromFullName(physicalName);
physicalTableName =
SchemaUtil.getTableNameFromFullName(physicalName);
List<ColumnName> requiredCols =
Lists.newArrayList(indexedColumnNames);
+ verifyIfDescViewsExtendPk(dataTable, config);
Review Comment:
nit: method name, can get confused with Descending order. Maybe use full
verb verifyIfDescendantViewsExtendsPk?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
