[
https://issues.apache.org/jira/browse/PHOENIX-7103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784061#comment-17784061
]
ASF GitHub Bot commented on PHOENIX-7103:
-----------------------------------------
stoty commented on PR #111:
URL:
https://github.com/apache/phoenix-connectors/pull/111#issuecomment-1801966731
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 18s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 10m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 13m 35s | master passed |
| +1 :green_heart: | compile | 1m 32s | master passed |
| +1 :green_heart: | scaladoc | 1m 12s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 12m 43s | the patch passed |
| +1 :green_heart: | compile | 1m 31s | the patch passed |
| +1 :green_heart: | scalac | 1m 31s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | scaladoc | 1m 12s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 28m 13s | phoenix5-spark in the patch
passed. |
| +1 :green_heart: | unit | 1m 8s | phoenix5-spark3 in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 16s | The patch does not generate
ASF License warnings. |
| | | 72m 41s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-111/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/111 |
| Optional Tests | dupname asflicense scalac scaladoc unit compile |
| uname | Linux 90c252c3f27f 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19
13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 062b34c |
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-111/2/testReport/
|
| Max. process+thread count | 1922 (vs. ulimit of 30000) |
| modules | C: phoenix5-spark phoenix5-spark3 U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-111/2/console
|
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Phoenix-connectors uses the refactored ConnectionInfo class
> ------------------------------------------------------------
>
> Key: PHOENIX-7103
> URL: https://issues.apache.org/jira/browse/PHOENIX-7103
> Project: Phoenix
> Issue Type: Bug
> Components: connectors, spark-connector
> Affects Versions: connectors-6.0.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> Which no longer exists where it is expected.
> While ideally the whole logic should be changed as in the current Java Spark
> connector, until that is done, we can just avoid ConnectionInfo, and process
> the quorum with simple String oprtaions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
