ranganathg commented on PR #1738: URL: https://github.com/apache/phoenix/pull/1738#issuecomment-1814440282
Just trying to think loud (I haven't looked at all the CDC related PRs also). While looking at the PR at a high level, I was thinking would it better to refactor the code to follow a design pattern which could possibly avoid having if conditions to check if(feature == CDC) to using inheritance? May be while INDEXing changes were added it could have been much over head to do such refactoring. Does my comment make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
