[ 
https://issues.apache.org/jira/browse/PHOENIX-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786754#comment-17786754
 ] 

ASF GitHub Bot commented on PHOENIX-7014:
-----------------------------------------

ranganathg commented on PR #1738:
URL: https://github.com/apache/phoenix/pull/1738#issuecomment-1814440282

   Just trying to think loud (I haven't looked at all the CDC related PRs 
also). While looking at the PR at a high level, I was thinking would it better 
to refactor the code to follow a design pattern which could possibly avoid 
having if conditions to check if(feature == CDC) to using inheritance? May be 
while INDEXing changes were added it could have been much over head to do such 
refactoring. Does my comment make sense?




> CDC query complier and optimizer
> --------------------------------
>
>                 Key: PHOENIX-7014
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7014
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Viraj Jasani
>            Assignee: Hari Krishna Dara
>            Priority: Major
>
> For CDC table type, the query optimizer should be able to query from the 
> uncovered global index table with data table associated with the given CDC 
> table.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to