[
https://issues.apache.org/jira/browse/PHOENIX-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788166#comment-17788166
]
ASF GitHub Bot commented on PHOENIX-7101:
-----------------------------------------
jinggou commented on code in PR #1737:
URL: https://github.com/apache/phoenix/pull/1737#discussion_r1399810185
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexBuildTimestampIT.java:
##########
@@ -249,7 +249,8 @@ public void testCellTimestamp() throws Exception {
String selectSql = String.format("SELECT * FROM %s WHERE val =
'abc'", (view ? viewName : dataTableName));
conn = DriverManager.getConnection(getUrl());
// assert we are pulling from index table
- assertExplainPlan(conn, localIndex, selectSql, dataTableName,
(view ? "_IDX_" + dataTableName : indexName));
+ assertExplainPlan(conn, localIndex, selectSql, dataTableName,
(view && !localIndex ?
+ "_IDX_" + dataTableName : indexName));
Review Comment:
we have that format inside assertExplainPlan function here
[phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java](https://github.com/apache/phoenix/pull/1737/files/62de58788aed657170cdcfac5fa827cb4230b781#diff-7bc5a84dbd349aa5114d2f1aab874fd3efed28ce5123bcf4ce59bfe6589031ac)
> Explain plan to output local index name if it is used
> -----------------------------------------------------
>
> Key: PHOENIX-7101
> URL: https://issues.apache.org/jira/browse/PHOENIX-7101
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.1.3
> Reporter: Viraj Jasani
> Assignee: Jing Yu
> Priority: Major
> Fix For: 5.2.0, 5.1.4
>
>
> When we create local index on the table, we use different column family to
> store the index data. When we use Explain plan for any query that uses local
> index, since the hbase table name remains same for the local index, we only
> output that table name. To provide more clarity, we should output local index
> name in the Explain plan output if the local index is to be used.
> When local index is used, we should output in the format
> "${local_index}(${physical_table_name})" instead of "${physical_table_name}".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
