[ 
https://issues.apache.org/jira/browse/PHOENIX-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788799#comment-17788799
 ] 

Istvan Toth edited comment on PHOENIX-7118 at 11/23/23 9:30 AM:
----------------------------------------------------------------

It seems like PhoenixMetricsSink only gets loaded if it is explcitly defined in 
a hadoop-metrics2*.properties file, which is likely not the case for most 
Spark connector installations.
Triggering the problem can be avioded by not trying to load Phoenix metrics 
sink, which is to be removed in 5.2 anyway.

hadoop-client-api does incluse MetricsSink / MetricsPlugin, and it expects 
*org/apache/hadoop/shaded/org/apache/commons/configuration2* there.

So all three variations are possible.


was (Author: stoty):
It seems like PhoenixMetricsSink only gets loaded if it is explcitly defined in 
a hadoop-metrics2*.properties file, which is likely not the case for most 
Spark connector installations.
Triggering the problem can be avioded by not trying to load Phoenix metrics 
sink, which is to be removed in 5.2 anyway.

hbase-client-api does incluse MetricsSink / MetricsPlugin, and it expects 
*org/apache/hadoop/shaded/org/apache/commons/configuration2* there.

So all three variations are possible.

> Fix Shading Regressions in Connectors and Shade Hive for 
> hbase-shaded-mapreduce
> -------------------------------------------------------------------------------
>
>                 Key: PHOENIX-7118
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7118
>             Project: Phoenix
>          Issue Type: Bug
>          Components: connectors, hive-connector, spark-connector
>    Affects Versions: connectors-6.0.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> It seems like sometime during the refactors, we have broken the shading, 
> particularly the exclusions / provided settings.
> Only the Spark3 connector shading looks correct, both the Hive and Spark2 
> connector shadings seem to have regressed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to