[
https://issues.apache.org/jira/browse/PHOENIX-6939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790247#comment-17790247
]
ASF GitHub Bot commented on PHOENIX-6939:
-----------------------------------------
stoty commented on PR #119:
URL:
https://github.com/apache/phoenix-connectors/pull/119#issuecomment-1828501217
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 10m 25s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 16m 12s | master passed |
| +1 :green_heart: | compile | 2m 9s | master passed |
| +1 :green_heart: | javadoc | 1m 1s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 12m 48s | the patch passed |
| +1 :green_heart: | compile | 2m 5s | the patch passed |
| -1 :x: | javac | 2m 5s | root generated 20 new + 1388 unchanged - 20
fixed = 1408 total (was 1408) |
| -1 :x: | whitespace | 0m 0s | The patch has 3 line(s) that end in
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML
file. |
| -1 :x: | javadoc | 0m 19s | phoenix5-hive generated 20 new + 1061
unchanged - 20 fixed = 1081 total (was 1081) |
| -1 :x: | javadoc | 0m 33s | root generated 20 new + 1401 unchanged -
20 fixed = 1421 total (was 1421) |
||| _ Other Tests _ |
| -1 :x: | unit | 14m 10s | root in the patch failed. |
| -1 :x: | asflicense | 0m 26s | The patch generated 3 ASF License
warnings. |
| | | 67m 41s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-119/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/119 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 88ee31b7e768 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2
15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 26c1aba |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| javac |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-119/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-119/1/artifact/yetus-general-check/output/whitespace-eol.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-119/1/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix5-hive.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-119/1/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-119/1/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-119/1/testReport/
|
| asflicense |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-119/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
|
| Max. process+thread count | 1790 (vs. ulimit of 30000) |
| modules | C: phoenix5-hive phoenix5-hive-shaded . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-119/1/console
|
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Change phoenix-hive connector shading to work with hbase-shaded-mapreduce
> -------------------------------------------------------------------------
>
> Key: PHOENIX-6939
> URL: https://issues.apache.org/jira/browse/PHOENIX-6939
> Project: Phoenix
> Issue Type: Improvement
> Components: connectors, hive-connector
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> The Hive 3 Hbase classpath is a huge mess, and as a result, we need to
> replace the HBase jars in Hive to ever have a chance to work.
> Provide a shaded phoenix hive connector JAR that uses existing
> hbase-shaded-mapreduce JARs added to the hive classpath.
> This is the same shading needed by Hive 4 (which requires some more API
> changes)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
