[
https://issues.apache.org/jira/browse/PHOENIX-7109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790967#comment-17790967
]
ASF GitHub Bot commented on PHOENIX-7109:
-----------------------------------------
stoty commented on code in PR #1741:
URL: https://github.com/apache/phoenix/pull/1741#discussion_r1408901190
##########
phoenix-core/src/main/java/org/apache/phoenix/iterate/OffsetResultIterator.java:
##########
@@ -49,7 +49,7 @@ public Tuple next() throws SQLException {
while (rowCount < offset) {
Tuple tuple = super.next();
if (tuple == null) { return null; }
- if (isDummy(tuple)) {
Review Comment:
very minor nit:
.size() is probably cheaper than isDummy(), so switching the two predicates
may be advised.
> Incorrect query results when using OFFSET
> -----------------------------------------
>
> Key: PHOENIX-7109
> URL: https://issues.apache.org/jira/browse/PHOENIX-7109
> Project: Phoenix
> Issue Type: Bug
> Components: phoenix
> Affects Versions: 5.1.3
> Reporter: Aron Attila Meszaros
> Assignee: Aron Attila Meszaros
> Priority: Major
>
> Steps to reproduce:
> # create table test (i1 integer not null, i2 integer not null, i3 integer,
> i4 integer, CONSTRAINT pk PRIMARY KEY (i1, i2));
> # upsert into test select rand()*40, rand()*10000000, null, rand()*100 from
> SYSTEM.CATALOG limit 130000;
> # upsert into test select rand()*40, rand()*10000000, null, rand()*100 from
> test limit 130000;
> Repeat step 3 a few times, then run
> {noformat}
> select * from test where i1=10 and i4=20 offset X;{noformat}
> where X is bigger than the number of rows satisfying the condition.
> There are rows returned by phoenix (expected result is empty set.)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
