stoty commented on code in PR #121:
URL:
https://github.com/apache/phoenix-connectors/pull/121#discussion_r1410463953
##########
phoenix5-hive-shaded/pom.xml:
##########
@@ -266,27 +401,74 @@
<!-- Extras compared to Hadoop -->
<!-- Hbase classes - Maybe these could be shaded as well ? -->
<exclude>org/apache/hbase/**</exclude>
+ <!-- We use the spark classpath directly -->
+ <exclude>org/apache/spark/**</exclude>
Review Comment:
It's not, but it doesn't hurt, and I copied the whole section.
If we removed it, we wouldn't be able to copy-paste relocation fixes between
the modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
