[ 
https://issues.apache.org/jira/browse/PHOENIX-7059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792322#comment-17792322
 ] 

Istvan Toth commented on PHOENIX-7059:
--------------------------------------

[https://github.com/apache/phoenix/blob/b241252307e403483741760eaa4894581e3dab3d/phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java#L128C11-L128C11]
 

for example.
I really suggest waiting a few days, I plan to merge PHOENIX-6053 early next 
week.

> De-duplicate HBase string contants in Phoenix
> ---------------------------------------------
>
>                 Key: PHOENIX-7059
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7059
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 5.2.0, 5.1.3
>            Reporter: Istvan Toth
>            Assignee: Jing Yu
>            Priority: Minor
>
> We are re-defining a lot of HBase property and class names in Phoenix.
> We should either directly replace the String constats in Phoenix, or 
> initialize them from the HBase constants.
> We need to be careful not to introduce additional dependencies (i.e. do not 
> replace constants in client-side code that are defined in hbase-server).
> We also need to be careful to replace only constants that are present in all 
> supported HBase version (2.1+, as of writing this)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to