sanjeet006py commented on code in PR #1751:
URL: https://github.com/apache/phoenix/pull/1751#discussion_r1420323531
##########
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -3153,6 +3158,7 @@ public boolean isViewReferenced() {
} else {
tableUpsert.setNull(36, Types.VARCHAR);
}
+ tableUpsert.setLong(37, maxLookbackAge);
Review Comment:
Actually I was of the understanding that I took care of converting existing
NULLs in SYSCAT to 0 (default) via:
https://github.com/sanjeet006py/phoenix/blob/PHOENIX-7006/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1448,
but I agree it good to be consistent around definition of max lookback age not
defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
