palashc commented on code in PR #1753:
URL: https://github.com/apache/phoenix/pull/1753#discussion_r1424388251
##########
phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java:
##########
@@ -650,16 +650,13 @@ public static Configuration
setUpConfigForMiniCluster(Configuration conf, ReadOn
}
/*
- Set property hbase.coprocessor.regionserver.classes to include
PhoenixRegionServerEndpoint
- by default. If some other regionserver coprocs are already present
then append
- PhoenixRegionServerEndpoint to the existing coprocs.
+ Set property hbase.coprocessor.regionserver.classes to include
PhoenixRegionServerEndpoint
+ by default, if some other regionserver coprocs are not already present.
*/
private static void setPhoenixRegionServerEndpoint(Configuration conf) {
String value = conf.get(REGIONSERVER_COPROCESSOR_CONF_KEY);
if (value == null) {
value = PhoenixRegionServerEndpoint.class.getName();
- } else {
Review Comment:
@shahrs87 why was this change needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
