[ 
https://issues.apache.org/jira/browse/PHOENIX-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795894#comment-17795894
 ] 

ASF GitHub Bot commented on PHOENIX-7144:
-----------------------------------------

tkhurana commented on code in PR #1755:
URL: https://github.com/apache/phoenix/pull/1755#discussion_r1424435964


##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixTableLevelMetricsIT.java:
##########
@@ -1218,6 +1216,62 @@ private static void assertMetricValue(Metric m, 
MetricType checkType, long compa
         }
     }
 
+    @Test  public void testMetricsWithIndexUsage() throws Exception {

Review Comment:
   Nit: Move the function name to new line





> TableLevel Phoenix Metrics returns base tableName when queried for Index 
> Table.
> -------------------------------------------------------------------------------
>
>                 Key: PHOENIX-7144
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7144
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: vikas meka
>            Assignee: vikas meka
>            Priority: Major
>             Fix For: 5.2.0
>
>
> TableClient Metrics returns BaseTable Name when Indexes are used. Phoenix 
> Result set uses Index TableName while storing as DDL queries use BaseTable 
> Name while storing metrics in HashMap.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to