ranganathg commented on code in PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430370140


##########
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateIndexCompiler.java:
##########
@@ -110,6 +111,8 @@ private String getValue(PDataType type) {
             return "ARRAY[" + getValue(PDate.INSTANCE) + "]";
         } else if (type instanceof PArrayDataType) {
             return "ARRAY" + type.getSampleValue().toString();
+        } else if (type instanceof PJson) {
+            return null;

Review Comment:
   There was a problem with that - initially i was returning '{"a":1}' but when 
I was running tests creating the index with the expression, I found that the 
jsonPath in the expression is applied on the sample json and that ran into 
issue. Didn't debug it further and rather choose to return null. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to