[ 
https://issues.apache.org/jira/browse/PHOENIX-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798272#comment-17798272
 ] 

ASF GitHub Bot commented on PHOENIX-7155:
-----------------------------------------

ranganathg commented on code in PR #1767:
URL: https://github.com/apache/phoenix/pull/1767#discussion_r1430370140


##########
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateIndexCompiler.java:
##########
@@ -110,6 +111,8 @@ private String getValue(PDataType type) {
             return "ARRAY[" + getValue(PDate.INSTANCE) + "]";
         } else if (type instanceof PArrayDataType) {
             return "ARRAY" + type.getSampleValue().toString();
+        } else if (type instanceof PJson) {
+            return null;

Review Comment:
   There was a problem with that - initially i was returning '{"a":1}' but when 
I was running tests creating the index with the expression, I found that the 
jsonPath in the expression is applied on the sample json and that ran into 
issue. Didn't debug it further and rather choose to return null. 





> Validate Partial Index support with JSON
> ----------------------------------------
>
>                 Key: PHOENIX-7155
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7155
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Ranganath Govardhanagiri
>            Assignee: Ranganath Govardhanagiri
>            Priority: Major
>
> Phoenix has recently added support for Partial Indexes - PHOENIX-7032. This 
> task is to validate if Indexes built on top of JSON documents support Partial 
> Indexes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to