Kerasone commented on PR #1606:
URL: https://github.com/apache/phoenix/pull/1606#issuecomment-1869211182
I'm so sorry,I'll do it quickly,thanks for your help
---- Replied Message ----
| From | Geoffrey ***@***.***> |
| Date | 05/19/2023 03:57 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [apache/phoenix] PHOENIX-6955 The value of region
metric--lastMajorCompactionAge is wrong，when the hfile is buckload file (PR
#1606) |
@gjacoby126 requested changes on this pull request.
Thanks for the patch. Could we also please have a simple test to confirm
that the bug's fixed?
In
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/MultiHfileOutputFormat.java:
> @@ -265,7 +265,8 @@ private WriterLength getNewWriter(final String
tableName , byte[] family, Config
.withBytesPerCheckSum(CompatUtil.getBytesPerChecksum(conf))
.withBlockSize(blockSize)
.withDataBlockEncoding(encoding)
-
.withCellComparator(CellComparatorImpl.COMPARATOR);
+
.withCellComparator(CellComparatorImpl.COMPARATOR)
+
.withCreateTime(System.currentTimeMillis());;
This should probably be EnvironmentEdgeManager.currentTime() so that tests
can override the timestamp correctly.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
