[ https://issues.apache.org/jira/browse/PHOENIX-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801066#comment-17801066 ]
ASF GitHub Bot commented on PHOENIX-6968: ----------------------------------------- shahrs87 commented on code in PR #1691: URL: https://github.com/apache/phoenix/pull/1691#discussion_r1437917968 ########## phoenix-core/src/main/protobuf/RegionServerEndpointService.proto: ########## @@ -36,7 +36,24 @@ message LastDDLTimestampRequest { required int64 lastDDLTimestamp = 4; } -service RegionServerCoprocService { +message InvalidateServerMetadataCache { Review Comment: We haven't deployed the previous changes anywhere. This was still in the dev branch so it was not important to handle backwards compatibility. But I am not sure how we would handle the backwards compatibility once the release was cut off. > Create PhoenixRegionServerEndpoint#invalidateCache method to invalidate cache. > ------------------------------------------------------------------------------ > > Key: PHOENIX-6968 > URL: https://issues.apache.org/jira/browse/PHOENIX-6968 > Project: Phoenix > Issue Type: Sub-task > Reporter: Rushabh Shah > Assignee: Rushabh Shah > Priority: Major > > Whenever we update metadata (like alter table add column, drop table), we > need to invalidate metadata cache entry (introduced by PHOENIX-6943) on all > the regionservers which has that cache entry. First step would be to issue an > invalidate command on all the regionservers irrespective of whether that > regionserver has the cache entry. We can further optimize by invalidating > only on RS that has that cache entry. > In PHOENIX-6988 we created PhoenixRegionServerEndpoint implementing > RegionServerCoprocessor. We can create a new method in this co-proc something > like invalidateCache(CacheEntry) to invalidate cache for a given > table/view/index. -- This message was sent by Atlassian Jira (v8.20.10#820010)