[
https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801705#comment-17801705
]
ASF GitHub Bot commented on PHOENIX-7130:
-----------------------------------------
stoty commented on PR #1745:
URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1873770999
I have tested this now, but the shading time difference is seems to be
minimal.
On my machine it takes ~3:20 with the shaded sources, and ~3:05 without them.
I don't have a problem with committing this, but I wander what kind of
improvement do you see with the patch, @NihalJain ?
Also I have just merged phoenix-client-lite, you may want to update the
patch to add same change there.
> Support skipping of shade sources jar creation
> ----------------------------------------------
>
> Key: PHOENIX-7130
> URL: https://issues.apache.org/jira/browse/PHOENIX-7130
> Project: Phoenix
> Issue Type: Improvement
> Components: phoenix
> Reporter: Nihal Jain
> Assignee: Nihal Jain
> Priority: Minor
> Labels: build
>
> Shade sources jar creation takes a lot of time and we do not want to do this
> for every dev build (in our internal phoenix jenkins). Hence with this Jira,
> will add a profile to disable shade jar creation optionally by running with
> '-PskipShadeSources'.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
