haridsv commented on code in PR #1794:
URL: https://github.com/apache/phoenix/pull/1794#discussion_r1457558693
##########
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/CDCGlobalIndexRegionScanner.java:
##########
@@ -271,6 +281,7 @@ private Result getCDCImage(
protected void scanDataTableRows(long startTime) throws IOException {
super.scanDataTableRows(startTime);
List<List<Cell>> indexRowList = new ArrayList<>();
+ Map<Long, ImmutableBytesPtr> indexDeleteFamilyCellMap = new
HashMap<>();
Review Comment:
Just wondering why you are using this intermediate variable.
##########
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/CDCGlobalIndexRegionScanner.java:
##########
@@ -76,6 +77,8 @@ public class CDCGlobalIndexRegionScanner extends
UncoveredGlobalIndexRegionScann
// Map<dataRowKey: Map<TS: Map<qualifier: Cell>>>
private Set<PTable.CDCChangeScope> cdcChangeScopeSet;
+ private Map<Long, ImmutableBytesPtr> indexDeleteFamilyCellMap;
Review Comment:
Now that you changed the value type per our offline discussion, this can be
better named. How about `deleteFamilyTS2DataRowKeyMap`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
