[
https://issues.apache.org/jira/browse/PHOENIX-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813110#comment-17813110
]
ASF GitHub Bot commented on PHOENIX-7194:
-----------------------------------------
stoty commented on code in PR #1814:
URL: https://github.com/apache/phoenix/pull/1814#discussion_r1474041434
##########
dev/phoenix-personality.sh:
##########
@@ -155,9 +155,6 @@ function personality_modules
# I have been unable to get Jacoco running reliably on ASF Jenkins, thus it
is disabled.
extra="--threads=1 -DPhoenixPatchProcess -Dskip.code-coverage "
- if [[ "${PATCH_BRANCH}" = 4* ]]; then
Review Comment:
This is unrelated, but we don't need to support 4.x anymore.
> Yetus does not run tests in phoenix-core if phoenix-core-client or
> phoenix-core-server changes
> ----------------------------------------------------------------------------------------------
>
> Key: PHOENIX-7194
> URL: https://issues.apache.org/jira/browse/PHOENIX-7194
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 5.2.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Blocker
> Labels: CI, test
>
> With the code split, application code and tests are no longer in the same
> module, which confuses Yetus.
> Hack around this, so that yetus runs the tests in phoenix-core when the code
> it depends on changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
