tkhurana commented on code in PR #1807:
URL: https://github.com/apache/phoenix/pull/1807#discussion_r1475407273
##########
phoenix-core-client/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -940,8 +940,13 @@ private boolean
addColumnsAndIndexesFromAncestors(MetaDataMutationResult result,
if (!alwaysAddAncestorColumnsAndIndexes &&
!result.wasUpdated() && !parentResult.wasUpdated()) {
return false;
}
- result.setTable(ViewUtil.addDerivedColumnsAndIndexesFromParent(
- connection, table, parentTable));
+
+ PTable pTableWithDerivedColumnsAndIndexes
Review Comment:
You can remove the hasIndexId check from line 908 and use that here
something like `if (!index || hasIndexId) call
ViewUtil.addDerivedColumnsAndIndexesFromParent`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
