TheNamesRai commented on code in PR #1813:
URL: https://github.com/apache/phoenix/pull/1813#discussion_r1478425940
##########
phoenix-core/src/main/java/org/apache/phoenix/util/CDCUtil.java:
##########
@@ -110,4 +109,25 @@ public static Scan initForRawScan(Scan scan) {
}
return scan;
}
+
+ public static int compareCellFamilyAndQualifier(byte[] columnFamily1,
+ byte[] columnQual1,
+ byte[] columnFamily2,
+ byte[] columnQual2) {
+ int familyNameComparison = CDCUtil.compare(columnFamily1,
columnFamily2);
+ if (familyNameComparison != 0) {
+ return familyNameComparison;
+ }
+ return CDCUtil.compare(columnQual1, columnQual2);
Review Comment:
Arrays.compare is available after Java 9. To keep supporting Java 8, i
created a new function to do the same.
As per it's implementation, both seems equally efficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
