[
https://issues.apache.org/jira/browse/PHOENIX-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816824#comment-17816824
]
ASF GitHub Bot commented on PHOENIX-7166:
-----------------------------------------
tkhurana commented on code in PR #1778:
URL: https://github.com/apache/phoenix/pull/1778#discussion_r1486954585
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/ViewUtil.java:
##########
@@ -484,7 +484,8 @@ public static void addIndexesFromParent(PhoenixConnection
connection, PTable vie
.setTableName(modifiedIndexName)
.setViewStatement(viewStatement)
.setUpdateCacheFrequency(view.getUpdateCacheFrequency())
- .setTenantId(view.getTenantId())
+ //retain the tenantId from the index being
inherited
Review Comment:
@palashc Can you add a testcase in whereoptimizer test with a global view
and global view index and a query on tenant view uses index and the scan start
row has the tenantid bytes similar to this
https://github.com/apache/phoenix/blob/master/phoenix-core/src/test/java/org/apache/phoenix/compile/WhereOptimizerTest.java#L2670-L2671
> Set default values of feature flags introduced by metadata caching redesign
> ---------------------------------------------------------------------------
>
> Key: PHOENIX-7166
> URL: https://issues.apache.org/jira/browse/PHOENIX-7166
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Palash Chauhan
> Assignee: Palash Chauhan
> Priority: Major
>
> We have 3 feature flags which will control the metadata caching redesign
> functionality.
> 1. phoenix.metadata.invalidate.cache.enabled (default = false)
> 2. phoenix.ddl.timestamp.validation.enabled (default = false)
> 3. phoenix.default.update.cache.frequency (default = ALWAYS = 0)
> Once the implementation is complete, we can set the boolean config flags to
> True and set default Update Cache Frequency to NEVER = Long.MAX_VALUE.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
