jpisaac commented on code in PR #1752:
URL: https://github.com/apache/phoenix/pull/1752#discussion_r1491386447
##########
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java:
##########
@@ -368,6 +368,8 @@ public SQLException newException(SQLExceptionInfo info) {
TTL_ALREADY_DEFINED_IN_HIERARCHY(10958, "44A40", TTL
+ " property is already defined in hierarchy for this entity"),
+ VIEW_TTL_NOT_ENABLED(10959,"44A41", TTL +
+ " property can not be set on Views as phoenix.view.ttl.enabled is
false"),
Review Comment:
nit: typo should be lowercase "views"
##########
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java:
##########
@@ -1470,6 +1475,121 @@ public static void
copyTTLValuesFromPhoenixTTLColumnToTTLColumn(
}
+ public static void moveHBaseLevelTTLToSYSCAT(PhoenixConnection
oldMetaConnection,
+ Map<String, String> options)
throws IOException {
+ long numOfTableThatHasTTLMoved = 0;
+ ReadOnlyProps readOnlyProps =
oldMetaConnection.getQueryServices().getProps();
+ TableName sysCat =
SchemaUtil.getPhysicalTableName(SYSTEM_CATALOG_NAME, readOnlyProps);
+
+ LOGGER.debug(String.format("SYSTEM CATALOG tabled use for copying TTL
values: %s", sysCat.toString()));
Review Comment:
nit: typo "table used'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
