[
https://issues.apache.org/jira/browse/PHOENIX-6996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817744#comment-17817744
]
ASF GitHub Bot commented on PHOENIX-6996:
-----------------------------------------
jpisaac commented on code in PR #1752:
URL: https://github.com/apache/phoenix/pull/1752#discussion_r1491386447
##########
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java:
##########
@@ -368,6 +368,8 @@ public SQLException newException(SQLExceptionInfo info) {
TTL_ALREADY_DEFINED_IN_HIERARCHY(10958, "44A40", TTL
+ " property is already defined in hierarchy for this entity"),
+ VIEW_TTL_NOT_ENABLED(10959,"44A41", TTL +
+ " property can not be set on Views as phoenix.view.ttl.enabled is
false"),
Review Comment:
nit: typo should be lowercase "views"
##########
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java:
##########
@@ -1470,6 +1475,121 @@ public static void
copyTTLValuesFromPhoenixTTLColumnToTTLColumn(
}
+ public static void moveHBaseLevelTTLToSYSCAT(PhoenixConnection
oldMetaConnection,
+ Map<String, String> options)
throws IOException {
+ long numOfTableThatHasTTLMoved = 0;
+ ReadOnlyProps readOnlyProps =
oldMetaConnection.getQueryServices().getProps();
+ TableName sysCat =
SchemaUtil.getPhysicalTableName(SYSTEM_CATALOG_NAME, readOnlyProps);
+
+ LOGGER.debug(String.format("SYSTEM CATALOG tabled use for copying TTL
values: %s", sysCat.toString()));
Review Comment:
nit: typo "table used'?
> Provide an upgrade path for Phoenix tables with HBase TTL to move their TTL
> spec to SYSTEM.CATALOG
> --------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6996
> URL: https://issues.apache.org/jira/browse/PHOENIX-6996
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Jacob Isaac
> Assignee: Lokesh Khurana
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
