shahrs87 commented on PR #1845: URL: https://github.com/apache/phoenix/pull/1845#issuecomment-1984174529
> INSTANCE variable does not match static variable name pattern but it was already present in code, we just refactored in this PR. Can we fix this just by following the pattern that it expects? > new class does have license but it's not a line by line match to what is expected, I took it from other classes in the codebase. Do we know what is expected? If yes then lets make checkstyle happy. > This is about storing the conf object inside the server metadata cache, also something which was only refactored into a new class in this PR. Agree that this is just refactoring. But I think the correct fix is creating a new conf object something like this: `this.conf = new Configuration(conf); ` Lets do these changes to make checkstyle and spotbugs happy. @palashc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
