[
https://issues.apache.org/jira/browse/PHOENIX-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824501#comment-17824501
]
ASF GitHub Bot commented on PHOENIX-7251:
-----------------------------------------
shahrs87 commented on PR #1845:
URL: https://github.com/apache/phoenix/pull/1845#issuecomment-1984174529
> INSTANCE variable does not match static variable name pattern but it was
already present in code, we just refactored in this PR.
Can we fix this just by following the pattern that it expects?
> new class does have license but it's not a line by line match to what is
expected, I took it from other classes in the codebase.
Do we know what is expected? If yes then lets make checkstyle happy.
> This is about storing the conf object inside the server metadata cache,
also something which was only refactored into a new class in this PR.
Agree that this is just refactoring. But I think the correct fix is creating
a new conf object something like this:
`this.conf = new Configuration(conf);
`
Lets do these changes to make checkstyle and spotbugs happy. @palashc
> Refactor server-side code to support multiple ServerMetadataCache for HA tests
> ------------------------------------------------------------------------------
>
> Key: PHOENIX-7251
> URL: https://issues.apache.org/jira/browse/PHOENIX-7251
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Palash Chauhan
> Assignee: Palash Chauhan
> Priority: Major
>
> In the metadata caching re-design, `ServerMetadataCache` is required to be a
> singleton in the implementation. This affects tests for the HA use case
> because the coprocessors on the 2 clusters end up using the same
> `ServerMetadataCache`. All tests which execute queries with 1 of the clusters
> unavailable will fail.
> We can refactor the implementation in the following way to support HA test
> cases:
> 1. Create a `ServerMetadataCache` interface and use the current
> implementation as `ServerMetadataCacheImpl` for all other tests. This would
> be a singleton.
> 2. Implement `ServerMetadataCacheHAImpl` with a map of instances keyed on
> config.
> 3. Extend `PhoenixRegionServerEndpoint` and use `ServerMetadataCacheHAImpl`.
> 4. In HA tests, load this new endpoint on the region servers.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
