tkhurana commented on code in PR #1851:
URL: https://github.com/apache/phoenix/pull/1851#discussion_r1517442429
##########
phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java:
##########
@@ -247,6 +248,10 @@ private List<QueryPlan>
getApplicablePlansForSingleFlatQuery(QueryPlan dataPlan,
}
plans.add(0, hintedPlan);
}
+ if (dataPlan.getContext().getScanRanges().isPointLookup()
+ && stopAtBestPlan && dataPlan.isApplicable()) {
+ return Collections.<QueryPlan> singletonList(dataPlan);
+ }
Review Comment:
The optimizer will select the optimal plan from the list of plans. You can
test by commenting this logic. There is no need to duplicate code. It is
confusing to maintain. Same logic is in multiple places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
