[ 
https://issues.apache.org/jira/browse/PHOENIX-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829515#comment-17829515
 ] 

ASF GitHub Bot commented on PHOENIX-7172:
-----------------------------------------

stoty commented on code in PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#discussion_r1533754389


##########
phoenix-hbase-compat-2.6.0/src/main/java/org/apache/phoenix/compat/hbase/CompatIndexHalfStoreFileReader.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.compat.hbase;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.io.hfile.CacheConfig;
+import org.apache.hadoop.hbase.io.hfile.HFileInfo;
+import org.apache.hadoop.hbase.io.hfile.ReaderContext;
+import org.apache.hadoop.hbase.regionserver.StoreFileInfo;
+import org.apache.hadoop.hbase.regionserver.StoreFileReader;
+
+import java.io.IOException;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+
+public class CompatIndexHalfStoreFileReader  extends StoreFileReader {
+
+    public CompatIndexHalfStoreFileReader(final FileSystem fs, final 
CacheConfig cacheConf, final Configuration conf,
+                                          final ReaderContext readerContext, 
final HFileInfo hFileInfo) throws IOException {
+        super(readerContext, hFileInfo, cacheConf, new StoreFileInfo(conf, fs, 
new Path(fs.getHomeDirectory().toUri()),

Review Comment:
   You can see how I fixed this in #1815 





> Support HBase 2.6
> -----------------
>
>                 Key: PHOENIX-7172
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7172
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 5.2.0, 5.1.3
>            Reporter: Istvan Toth
>            Assignee: Richárd Antal
>            Priority: Major
>
> HBase 2.6.0 release work is ongoing.
> Make sure Phoenix works with it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to