[ 
https://issues.apache.org/jira/browse/PHOENIX-7288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831357#comment-17831357
 ] 

ASF GitHub Bot commented on PHOENIX-7288:
-----------------------------------------

stoty commented on PR #131:
URL: 
https://github.com/apache/phoenix-connectors/pull/131#issuecomment-2022765330

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   5m 17s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ master Compile Tests _ |
   | -1 :x: |  mvninstall  |   0m 12s |  root in master failed.  |
   | -1 :x: |  compile  |   0m 16s |  phoenix5-connectors-assembly in master 
failed.  |
   | -1 :x: |  javadoc  |   0m  6s |  phoenix5-connectors-assembly in master 
failed.  |
   ||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   0m  7s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m  9s |  phoenix5-connectors-assembly in the patch 
failed.  |
   | -1 :x: |  javac  |   0m  9s |  phoenix5-connectors-assembly in the patch 
failed.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  7s |  The patch has no ill-formed XML 
file.  |
   | -1 :x: |  javadoc  |   0m  5s |  phoenix5-connectors-assembly in the patch 
failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m  7s |  phoenix5-connectors-assembly in the patch 
failed.  |
   | +1 :green_heart: |  asflicense  |   0m 18s |  The patch does not generate 
ASF License warnings.  |
   |  |   |   7m  1s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.45 ServerAPI=1.45 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-131/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/131 |
   | Optional Tests | dupname asflicense javac javadoc unit xml compile |
   | uname | Linux eda547e3d09c 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 
15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-connectors-personality.sh |
   | git revision | master / 48472b4 |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-131/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
 |
   | compile | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-131/1/artifact/yetus-general-check/output/branch-compile-phoenix5-connectors-assembly.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-131/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-connectors-assembly.txt
 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-131/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-131/1/artifact/yetus-general-check/output/patch-compile-phoenix5-connectors-assembly.txt
 |
   | javac | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-131/1/artifact/yetus-general-check/output/patch-compile-phoenix5-connectors-assembly.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-131/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-connectors-assembly.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-131/1/artifact/yetus-general-check/output/patch-unit-phoenix5-connectors-assembly.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-131/1/testReport/
 |
   | Max. process+thread count | 52 (vs. ulimit of 30000) |
   | modules | C: phoenix5-connectors-assembly U: phoenix5-connectors-assembly |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-131/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Add unshaded connector JARs to connectors assembly
> --------------------------------------------------
>
>                 Key: PHOENIX-7288
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7288
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: connectors, hive-connector, spark-connector
>    Affects Versions: connectors-6.0.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Blocker
>
> The new phoenix-mapreduce jar makes the shaded connectors JARs obsolete (at 
> least for Phoenix 5.2+)
> Add the unshaded JARs to the assembly, and also add an option to to build the 
> assembly without the shaded JARs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to