virajjasani commented on code in PR #1874:
URL: https://github.com/apache/phoenix/pull/1874#discussion_r1554179954
##########
phoenix-core-client/src/main/java/org/apache/phoenix/util/ScanUtil.java:
##########
@@ -1615,14 +1615,21 @@ public static boolean
isIncompatibleClientForServerReturnValidRowKey(Scan scan)
public static PageFilter removePageFilter(Scan scan) {
Filter filter = scan.getFilter();
if (filter != null) {
+ PagingFilter pagingFilter = null;
if (filter instanceof PagingFilter) {
- filter = ((PagingFilter) filter).getDelegateFilter();
+ pagingFilter = (PagingFilter) filter;
+ filter = pagingFilter.getDelegateFilter();
if (filter == null) {
return null;
}
}
if (filter instanceof PageFilter) {
- scan.setFilter(null);
+ if (pagingFilter != null) {
+ pagingFilter.setDelegateFilter(null);
+ scan.setFilter(pagingFilter);
Review Comment:
This helps when filter is of both types: HBase PageFilter and Phoenix
PagingFilter (which happens only when LIMIT is present), so that we want to
retain PagingFilter for performing page timeouts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
