sanjeet006py commented on code in PR #1896:
URL: https://github.com/apache/phoenix/pull/1896#discussion_r1615288652
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java:
##########
@@ -1654,7 +1655,8 @@ else if (linkType == PHYSICAL_TABLE) {
else {
byte[] maxLookbackAgeInBytes =
result.getValue(TABLE_FAMILY_BYTES, MAX_LOOKBACK_AGE_BYTES);
if (maxLookbackAgeInBytes != null) {
- return
PLong.INSTANCE.getCodec().decodeLong(maxLookbackAgeInBytes, 0,
SortOrder.getDefault());
+ return
PInteger.INSTANCE.getCodec().decodeInt(maxLookbackAgeInBytes, 0,
Review Comment:
The test in MaxLookbackIT seems to be failing as MAX_LOOKBACK_AGE is of type
BIGINT in SYSCAT while we are decoding it via PInteger decoder instead of PLong
decoder. I think we need to change the type of MAX_LOOKBACK_AGE column in
SYSCAT to INTERGER. I tested the IT with MAX_LOOKBACK_AGE as INT column in
SYSCAT and it worked.
I am also checking other places where we might we using max lookback as long
and will update on comment. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
