ranganathg commented on code in PR #1897:
URL: https://github.com/apache/phoenix/pull/1897#discussion_r1618276259
##########
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##########
@@ -857,11 +864,30 @@ private void
getCurrentRowStates(ObserverContext<RegionCoprocessorEnvironment> c
if (keys.isEmpty()) {
return;
}
- Scan scan = new Scan();
- ScanRanges scanRanges = ScanRanges.createPointLookup(new
ArrayList<KeyRange>(keys));
- scanRanges.initializeScan(scan);
- SkipScanFilter skipScanFilter = scanRanges.getSkipScanFilter();
- scan.setFilter(skipScanFilter);
+
+ if (this.useBloomFilter) {
+ for (KeyRange key : keys) {
+ // Scan.java usage alters scan instances, safer to create scan
instance per usage
+ Scan scan = new Scan();
+ // create a scan with same start/stop row key scan#isGetScan()
+ // for bloom filters scan should be a get
+ scan.withStartRow(key.getLowerRange(), true);
+ scan.withStopRow(key.getLowerRange(), true);
Review Comment:
start and stop row is the same ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
