jinggou commented on code in PR #1884:
URL: https://github.com/apache/phoenix/pull/1884#discussion_r1622875454
##########
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##########
@@ -1308,6 +1345,19 @@ public void
postBatchMutateIndispensably(ObserverContext<RegionCoprocessorEnviro
try {
if (success) {
context.currentPhase = BatchMutatePhase.POST;
+ for (int i = 0; i < miniBatchOp.size(); i++) {
+ BatchMutateContext.UpdateStatus updateStatus =
context.getUpdateStatus(i);
+ if
(BatchMutateContext.UpdateStatus.UPDATE.equals(updateStatus)) {
+ byte[] retVal = PInteger.INSTANCE.toBytes(1);
+ Cell cell = PhoenixKeyValueUtil.newKeyValue(
+ miniBatchOp.getOperation(i).getRow(),
+ EMPTY_BYTE_ARRAY, EMPTY_BYTE_ARRAY, 0, retVal, 0,
+ retVal.length);
+ Result result = Result.create(new
ArrayList<>(Arrays.asList(cell)));
+ miniBatchOp.setOperationStatus(i,
+ new OperationStatus(OperationStatusCode.SUCCESS,
result));
+ }
+ }
Review Comment:
`updateStatusMap` is designed to replace the check of
`miniBatchOp.getOperationStatus(i) == IGNORE` to `context.getUpdateStatus(i) ==
BatchMutateContext.UpdateStatus.IGNORE`.
If we get rid of updateStatusMap, then we should change this check to
something like `miniBatchOp.size() == 1 && updateStatus ==
BatchMutateContext.UpdateStatus.IGNORE`, right? And we will also need to do the
size check in `addOnDupMutationsToBatch` when `setUpdateStatus`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
