[ 
https://issues.apache.org/jira/browse/PHOENIX-7366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868355#comment-17868355
 ] 

ASF GitHub Bot commented on PHOENIX-7366:
-----------------------------------------

richardantal commented on code in PR #133:
URL: 
https://github.com/apache/phoenix-connectors/pull/133#discussion_r1689389067


##########
phoenix5-spark3/src/main/java/org/apache/phoenix/spark/sql/connector/PhoenixDSRelation.java:
##########
@@ -0,0 +1,90 @@
+/*

Review Comment:
   This is not used anywhere, could you please remove it?



##########
phoenix5-spark/pom.xml:
##########
@@ -414,202 +419,160 @@
     </dependency>
 
     <dependency>
-      <!

> Use Phoenix 5.2 to compile phoenix-connectors
> ---------------------------------------------
>
>                 Key: PHOENIX-7366
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7366
>             Project: Phoenix
>          Issue Type: Task
>          Components: connectors, hive-connector, spark-connector
>    Affects Versions: connectors-6.0.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> This requires code changes, so after this connectors won't work with 5.1.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to