stoty commented on code in PR #158:
URL:
https://github.com/apache/phoenix-queryserver/pull/158#discussion_r1693071570
##########
bin/phoenix_queryserver_utils.py:
##########
@@ -131,11 +132,16 @@ def setPath():
phoenix_queryserver_classpath = os.path.join(current_dir, "../lib/*")
global phoenix_client_jar
- phoenix_client_jar = find(PHOENIX_CLIENT_JAR_PATTERN, phoenix_class_path)
+ phoenix_client_jar = find(PHOENIX_CLIENT_EMBEDDED_JAR_PATTERN,
phoenix_class_path)
if phoenix_client_jar == "":
- phoenix_client_jar = find(OLD_PHOENIX_CLIENT_JAR_PATTERN,
phoenix_class_path)
+ phoenix_client_jar =
findFileInPathWithoutRecursion(PHOENIX_CLIENT_EMBEDDED_JAR_PATTERN,
os.path.join(current_dir, ".."))
Review Comment:
I switched the ordering around so that we search for the each pattern in
both locations, instead of searching one location for each pattern, then
searching the other one for each pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]