[
https://issues.apache.org/jira/browse/PHOENIX-7145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868947#comment-17868947
]
ASF GitHub Bot commented on PHOENIX-7145:
-----------------------------------------
stoty commented on code in PR #158:
URL:
https://github.com/apache/phoenix-queryserver/pull/158#discussion_r1693071570
##########
bin/phoenix_queryserver_utils.py:
##########
@@ -131,11 +132,16 @@ def setPath():
phoenix_queryserver_classpath = os.path.join(current_dir, "../lib/*")
global phoenix_client_jar
- phoenix_client_jar = find(PHOENIX_CLIENT_JAR_PATTERN, phoenix_class_path)
+ phoenix_client_jar = find(PHOENIX_CLIENT_EMBEDDED_JAR_PATTERN,
phoenix_class_path)
if phoenix_client_jar == "":
- phoenix_client_jar = find(OLD_PHOENIX_CLIENT_JAR_PATTERN,
phoenix_class_path)
+ phoenix_client_jar =
findFileInPathWithoutRecursion(PHOENIX_CLIENT_EMBEDDED_JAR_PATTERN,
os.path.join(current_dir, ".."))
Review Comment:
I switched the ordering around so that we search for the each pattern in
both locations, instead of searching one location for each pattern, then
searching the other one for each pattern.
> Use embedded client in PQS startup script
> -----------------------------------------
>
> Key: PHOENIX-7145
> URL: https://issues.apache.org/jira/browse/PHOENIX-7145
> Project: Phoenix
> Issue Type: Bug
> Components: queryserver
> Reporter: Istvan Toth
> Priority: Minor
>
> We have made logging configurable in the queryserver.py script, and we add
> the required JARs to to the classpath.
> However, the user may supply the old non-embedded jar (or both variants)
> Try to find the embedded client JAR first, and log a warning if we only find
> the non-embedded variant (by file name pattern).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
