tkhurana commented on code in PR #1936:
URL: https://github.com/apache/phoenix/pull/1936#discussion_r1705873219
##########
phoenix-core-client/src/main/java/org/apache/phoenix/compile/QueryCompiler.java:
##########
@@ -125,21 +125,25 @@ public class QueryCompiler {
private final boolean optimizeSubquery;
private final Map<TableRef, QueryPlan> dataPlans;
private final boolean costBased;
+ private final StatementContext parentContext;
public QueryCompiler(PhoenixStatement statement, SelectStatement select,
ColumnResolver resolver, boolean projectTuples, boolean optimizeSubquery,
Map<TableRef, QueryPlan> dataPlans) throws SQLException {
this(statement, select, resolver, Collections.<PDatum>emptyList(),
null, new SequenceManager(statement), projectTuples, optimizeSubquery,
dataPlans);
}
public QueryCompiler(PhoenixStatement statement, SelectStatement select,
ColumnResolver resolver, BindManager bindManager, boolean projectTuples,
boolean optimizeSubquery, Map<TableRef, QueryPlan> dataPlans) throws
SQLException {
- this(statement, select, resolver, bindManager,
Collections.<PDatum>emptyList(), null, new SequenceManager(statement),
projectTuples, optimizeSubquery, dataPlans);
+ this(statement, select, resolver, bindManager,
Collections.<PDatum>emptyList(), null, new SequenceManager(statement),
projectTuples, optimizeSubquery, dataPlans, null);
}
public QueryCompiler(PhoenixStatement statement, SelectStatement select,
ColumnResolver resolver, List<? extends PDatum> targetColumns,
ParallelIteratorFactory parallelIteratorFactory, SequenceManager
sequenceManager, boolean projectTuples, boolean optimizeSubquery, Map<TableRef,
QueryPlan> dataPlans) throws SQLException {
- this(statement, select, resolver, new
BindManager(statement.getParameters()), targetColumns, parallelIteratorFactory,
sequenceManager, projectTuples, optimizeSubquery, dataPlans);
+ this(statement, select, resolver, new
BindManager(statement.getParameters()), targetColumns, parallelIteratorFactory,
sequenceManager, projectTuples, optimizeSubquery, dataPlans, null);
}
- public QueryCompiler(PhoenixStatement statement, SelectStatement select,
ColumnResolver resolver, BindManager bindManager, List<? extends PDatum>
targetColumns, ParallelIteratorFactory parallelIteratorFactory, SequenceManager
sequenceManager, boolean projectTuples, boolean optimizeSubquery, Map<TableRef,
QueryPlan> dataPlans) throws SQLException {
- this.statement = statement;
+ public QueryCompiler(PhoenixStatement statement, SelectStatement select,
ColumnResolver resolver, List<? extends PDatum> targetColumns,
ParallelIteratorFactory parallelIteratorFactory, SequenceManager
sequenceManager, boolean projectTuples, boolean optimizeSubquery, Map<TableRef,
QueryPlan> dataPlans, StatementContext parentContext) throws SQLException {
Review Comment:
Don't change public API signatures. It causes API compatibility issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
