stoty commented on code in PR #1951:
URL: https://github.com/apache/phoenix/pull/1951#discussion_r1713262906
##########
phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##########
@@ -366,7 +365,8 @@ public int getMaxPendingRowCount() {
private boolean shouldWALAppend = DEFAULT_PHOENIX_APPEND_METADATA_TO_WAL;
private boolean isNamespaceEnabled = false;
private boolean useBloomFilter = false;
-
+ private long lastTimestamp = 0;
Review Comment:
Longs are not atomic in Java.
Shouldn't this be atomic / volatile or be accessed in synchronized blocks
everywhere ?
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConcurrentMutationsExtendedIT.java:
##########
@@ -357,6 +358,8 @@ public void testConcurrentUpserts() throws Exception {
}
assertTrue("Ran out of time", doneSignal.await(120, TimeUnit.SECONDS));
+ System.out.println("Total upsert time in ms : "
Review Comment:
use LOGGER.info() instead ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
