stoty commented on code in PR #134:
URL:
https://github.com/apache/phoenix-connectors/pull/134#discussion_r1715103508
##########
phoenix5-spark/README.md:
##########
@@ -293,6 +293,17 @@ to executors as a comma-separated list against the key
`phoenixConfigs` i.e (Pho
Note that the same property values will be used for both the driver and
all executors and
these configurations are used each time a connection is made (both on the
driver and executors).
+- As of [PHOENIX-7377](https://issues.apache.org/jira/browse/PHOENIX-7377),
you can pass boolean parameter to avoid mapping
+ non default family columns to `columnFamily.columnName` by setting the key
`escapeColumnFamily` to `true` (default value: `false`), for ex:
Review Comment:
'escapeColumnFamily' is not a descriptive property name for this property.
Something like 'doNotMapColumnFamily' would describe the functionality
better.
##########
phoenix5-spark/src/it/scala/org/apache/phoenix/spark/PhoenixSparkIT.scala:
##########
@@ -913,4 +913,58 @@ class PhoenixSparkIT extends AbstractPhoenixSparkIT {
df.count() shouldEqual 1
}
+ test("Skip column family name when convert schema") {
Review Comment:
nit : "when converting shcema"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
