[
https://issues.apache.org/jira/browse/PHOENIX-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873853#comment-17873853
]
ASF GitHub Bot commented on PHOENIX-7377:
-----------------------------------------
stoty commented on PR #134:
URL:
https://github.com/apache/phoenix-connectors/pull/134#issuecomment-2290942942
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 11s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 10m 46s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 8s | root in master failed. |
| -1 :x: | compile | 0m 8s | phoenix5-spark in master failed. |
| -1 :x: | compile | 0m 9s | phoenix5-spark3 in master failed. |
| +1 :green_heart: | checkstyle | 0m 30s | master passed |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | javadoc | 0m 10s | phoenix5-spark3 in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in master failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in master failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in master failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark3 in master failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 6s | root in the patch failed. |
| -1 :x: | compile | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | compile | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | javac | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | javac | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scalac | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | scalac | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | checkstyle | 0m 9s | phoenix5-spark: The patch generated 1
new + 19 unchanged - 0 fixed = 20 total (was 19) |
| -1 :x: | checkstyle | 0m 9s | phoenix5-spark3: The patch generated 2
new + 14 unchanged - 0 fixed = 16 total (was 14) |
| -1 :x: | markdownlint | 0m 2s | The patch generated 11 new + 101
unchanged - 0 fixed = 112 total (was 101) |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | scaladoc | 0m 9s | phoenix5-spark3 in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix5-spark in the patch failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-spark3 in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | unit | 0m 8s | phoenix5-spark3 in the patch failed. |
| +1 :green_heart: | asflicense | 0m 17s | The patch does not generate
ASF License warnings. |
| | | 15m 33s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.46 ServerAPI=1.46 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/134 |
| Optional Tests | dupname asflicense markdownlint javac javadoc unit
spotbugs hbaseanti checkstyle compile scalac scaladoc |
| uname | Linux 2aceed8ceef9 5.15.0-117-generic #127-Ubuntu SMP Fri Jul 5
20:13:28 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 4c880e2 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-mvninstall-root.txt
|
| compile |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-compile-phoenix5-spark.txt
|
| compile |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-compile-phoenix5-spark3.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt
|
| scaladoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark.txt
|
| scaladoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-spark3.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/branch-spotbugs-phoenix5-spark3.txt
|
| mvninstall |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-mvninstall-root.txt
|
| compile |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
|
| compile |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
|
| javac |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
|
| javac |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
|
| scalac |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
|
| scalac |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark3.txt
|
| markdownlint |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/diff-patch-markdownlint.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/whitespace-eol.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt
|
| scaladoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark.txt
|
| scaladoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix5-spark3.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-spotbugs-phoenix5-spark3.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-unit-phoenix5-spark.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/artifact/yetus-general-check/output/patch-unit-phoenix5-spark3.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/testReport/
|
| Max. process+thread count | 52 (vs. ulimit of 30000) |
| modules | C: phoenix5-spark phoenix5-spark3 U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-134/4/console
|
| versions | git=2.7.4 maven=3.3.9 markdownlint=0.22.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Add option not to add CF to the Spark Column name in Spark Connector
> --------------------------------------------------------------------
>
> Key: PHOENIX-7377
> URL: https://issues.apache.org/jira/browse/PHOENIX-7377
> Project: Phoenix
> Issue Type: Bug
> Components: connectors, spark-connector
> Reporter: rejeb ben rejeb
> Assignee: rejeb ben rejeb
> Priority: Major
>
> The fix of the PHOENIX-4981 introduced a bracking change in the way the
> schema was inferred.
> In previous versions of the connector, for non default column family ,
> columns mapped to "columnName" in DataFrame. Now, they are mapped to
> "columnFamily.columnName".
> There are no unit tests that cover this case, all tests uses tables with
> default column family "0".
> The change is made is this [pull
> request|https://github.com/apache/phoenix/pull/402] (the project was moved to
> another git repo since):
> * In previous version code uses `ColumnInfo.getDisplayName` to define the
> name of the column in the DF.
> * The new class SparkSchemaUtil the method used is
> `ColumnInfo.getColumnName` which returns the columnName as
> `columnFamilyName.columnName`.
> The pull request is related to this ticket PHOENIX-4981 the change is not
> documented.
> This change breaks jobs reading from tables having a non default column
> family.
> The saprk3 connector have the same issue since code has been duplicated from
> spark2 module to spark3 module.
> Since V1 api has been modified to use same method to resolve schema it has
> the same behavior and it should not bcause they are now a deprecated classes
> and should not contain a braking change.
>
> *Resolution proposal:*
> The best way to fix the issue is to add a property to have both options for
> schema non default column family column name mapping.
> The issue is in spark connector and it's resolution will not have a side
> effect on other phoenix-connectors like phoenix5-hive for example.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
